]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: mpi3mr: Select CONFIG_SCSI_SAS_ATTRS
authorMichal Kubecek <mkubecek@suse.cz>
Mon, 17 Oct 2022 14:55:17 +0000 (16:55 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 22 Oct 2022 03:14:51 +0000 (03:14 +0000)
commit5a28b53516326cb0b17e955caeae4fbee1e94a55
tree76374182ed68183d65dcd7b484073ff4a4953d74
parentb337310988dd4a3a86f98ffbd796de9d81f4396e
scsi: mpi3mr: Select CONFIG_SCSI_SAS_ATTRS

Starting with commit 33266bf2c87e ("scsi: mpi3mr: Add helper functions to
manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and
CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols
used in mpi3mr_transport.c:

  ERROR: modpost: "sas_port_alloc_num" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
  ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
  ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
  ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
  ...

Select CONFIG_SCSI_SAS_ATTRS when CONFIG_SCSI_MPI3MR is enabled to prevent
inconsistent configs.

Link: https://lore.kernel.org/r/20221017145517.93BCB6043B@lion.mk-sys.cz
Fixes: 33266bf2c87e ("scsi: mpi3mr: Add helper functions to manage device's port")
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/Kconfig