]> git.baikalelectronics.ru Git - kernel.git/commit
spi: cadence: Correct initialisation of runtime PM again
authorMarek Vasut <marex@denx.de>
Fri, 16 Jul 2021 18:21:33 +0000 (20:21 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 19 Jul 2021 11:58:44 +0000 (12:58 +0100)
commit5a1fc3393f8ef232b64f4b08623e2de3977494c8
treed932a663f7b984d96be05a6ef18ff038845ce86a
parent70119b6093cc6f1905384424d663d07c285b19f0
spi: cadence: Correct initialisation of runtime PM again

The original implementation of RPM handling in probe() was mostly
correct, except it failed to call pm_runtime_get_*() to activate the
hardware. The subsequent fix, 70946d8860f3 ("spi: cadence: Correct
initialisation of runtime PM"), breaks the implementation further,
to the point where the system using this hard IP on ZynqMP hangs on
boot, because it accesses hardware which is gated off.

Undo 70946d8860f3 ("spi: cadence: Correct initialisation of runtime
PM") and instead add missing pm_runtime_get_noresume() and move the
RPM disabling all the way to the end of probe(). That makes ZynqMP
not hang on boot yet again.

Fixes: 70946d8860f3 ("spi: cadence: Correct initialisation of runtime PM")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20210716182133.218640-1-marex@denx.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence.c