]> git.baikalelectronics.ru Git - kernel.git/commit
fpga zynq: Check the bitstream for validity
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Wed, 1 Feb 2017 19:48:43 +0000 (12:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Feb 2017 14:20:44 +0000 (15:20 +0100)
commit59fe40491dcec56c242f97ce261b140826ee3e0a
tree0f87f727e68acab692280c556f6376237a68c64a
parent34a8c0daea7c0c6b10f6cc3910839540aa6a704a
fpga zynq: Check the bitstream for validity

There is no sense in sending a bitstream we know will not work, and
with the variety of options for bitstream generation in Xilinx tools
it is not terribly clear what the correct input should be.

This is particularly important for Zynq since auto-correction was
removed from the driver and the Zynq hardware only accepts a bitstream
format that is different from what the Xilinx tools typically produce.

Worse, the hardware provides no indication why the bitstream fails,
it simply times out if the input is wrong.

The best option here is to have the kernel print a message informing
the user they are using a malformed bistream and programming failure
isn't for any of the myriad of other reasons.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Acked-by: Alan Tull <atull@opensource.altera.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/zynq-fpga.c