]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI: sysfs: Prefer "compatible" modalias
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Fri, 22 Jan 2021 12:53:02 +0000 (20:53 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 25 Jan 2021 16:06:14 +0000 (17:06 +0100)
commit597c06cac517277e083081b0dfd25ee93a229b63
tree50db6e2eecd83a90482f1d74562e5c777323c258
parentbb30d010fcc33a6e59b2b501e4ba1a6982895115
ACPI: sysfs: Prefer "compatible" modalias

Commit 8eb63149d09f ("ACPI / scan: Rework modalias creation when
"compatible" is present") may create two "MODALIAS=" in one uevent
file if specific conditions are met.

This breaks systemd-udevd, which assumes each "key" in one uevent file
to be unique. The internal implementation of systemd-udevd overwrites
the first MODALIAS with the second one, so its kmod rule doesn't load
the driver for the first MODALIAS.

So if both the ACPI modalias and the OF modalias are present, use the
latter to ensure that there will be only one MODALIAS.

Link: https://github.com/systemd/systemd/pull/18163
Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Fixes: 8eb63149d09f ("ACPI / scan: Rework modalias creation when "compatible" is present")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: 4.1+ <stable@vger.kernel.org> # 4.1+
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/device_sysfs.c