]> git.baikalelectronics.ru Git - kernel.git/commit
thermal: int340x: fix build on 32-bit targets
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Nov 2021 18:56:25 +0000 (10:56 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Nov 2021 18:56:25 +0000 (10:56 -0800)
commit5911442cc69362f216fc8e2d002accb36f3e9b84
treec13c6c7939af16747d1b5559297ff08a2271f400
parentc9b0127f4f4cd51e643803b9b186bb2217c60ef1
thermal: int340x: fix build on 32-bit targets

Commit 9ebf1a5db1fc ("thermal/drivers/int340x: processor_thermal: Suppot
64 bit RFIM responses") started using 'readq()' to read 64-bit status
responses from the int340x hardware.

That's all fine and good, but on 32-bit targets a 64-bit 'readq()' is
ambiguous, since it's no longer an atomic access.  Some hardware might
require 64-bit accesses, and other hardware might want low word first or
high word first.

It's quite likely that the driver isn't relevant in a 32-bit environment
any more, and there's a patch floating around to just make it depend on
X86_64, but let's make it buildable on x86-32 anyway.

The driver previously just read the low 32 bits, so the hardware
certainly is ok with 32-bit reads, and in a little-endian environment
the low word first model is the natural one.

So just add the include for the 'io-64-nonatomic-lo-hi.h' version.

Fixes: 9ebf1a5db1fc ("thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c