]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Enable hotplug interrupts after querying hw capabilities.
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 9 Jun 2013 15:02:04 +0000 (16:02 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 10 Jun 2013 07:59:26 +0000 (09:59 +0200)
commit58ffdede92784d04713304214f8f7373de2bb385
tree8e7099fd13ba1f0b11f70f615b237876727d73ed
parent0bde8414a2bb1f1a5b9fe3c60f43b8fc92b56309
drm/i915: Enable hotplug interrupts after querying hw capabilities.

sdvo->hotplug_active is initialised during intel_sdvo_setup_outputs(),
and so we never enabled the hotplug interrupts on SDVO as we were
checking too early.

This regression has been introduced somewhere in the hpd rework for
the storm detection and handling starting with

commit 3174f6348f6688e99fd8449c32cdbe790c6ae369
Author: Egbert Eich <eich@suse.de>
Date:   Mon Feb 25 12:06:49 2013 -0500

    DRM/I915: Add enum hpd_pin to intel_encoder.

and the follow-up patches to use the new encoder->hpd_pin variable for
the different irq setup functions.

The problem is that encoder->hpd_pin was set up _before_ the output
setup was done and so before we could assess the hotplug capabilities
of the outputs on an sdvo encoder.

Reported-by: Alex Fiestas <afiestas@kde.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=58405
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
[danvet: Add regression note.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_sdvo.c