]> git.baikalelectronics.ru Git - kernel.git/commit
irqchip/gic-v3: Workaround inconsistent PMR setting on NMI entry
authorMarc Zyngier <maz@kernel.org>
Thu, 10 Jun 2021 14:13:46 +0000 (15:13 +0100)
committerMarc Zyngier <maz@kernel.org>
Thu, 10 Jun 2021 16:54:34 +0000 (17:54 +0100)
commit58d2d2468c7455f38a60b870793db27e5f2cb27b
tree8443040d60d218b637c70a70ba53badd9a888f38
parent87d9f8b77b5545016adf3cfc494e6ea6899acca7
irqchip/gic-v3: Workaround inconsistent PMR setting on NMI entry

The arm64 entry code suffers from an annoying issue on taking
a NMI, as it sets PMR to a value that actually allows IRQs
to be acknowledged. This is done for consistency with other parts
of the code, and is in the process of being fixed. This shouldn't
be a problem, as we are not enabling interrupts whilst in NMI
context.

However, in the infortunate scenario that we took a spurious NMI
(retired before the read of IAR) *and* that there is an IRQ pending
at the same time, we'll ack the IRQ in NMI context. Too bad.

In order to avoid deadlocks while running something like perf,
teach the GICv3 driver about this situation: if we were in
a context where no interrupt should have fired, transiently
set PMR to a value that only allows NMIs before acking the pending
interrupt, and restore the original value after that.

This papers over the core issue for the time being, and makes
NMIs great again. Sort of.

Fixes: 371c0033a3ba5eb1 ("arm64: entry: always set GIC_PRIO_PSR_I_SET during entry")
Co-developed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/lkml/20210610145731.1350460-1-maz@kernel.org
drivers/irqchip/irq-gic-v3.c