]> git.baikalelectronics.ru Git - kernel.git/commit
amd-xgbe: Use __napi_schedule() in BH context
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 16 Apr 2020 15:57:40 +0000 (17:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Apr 2020 07:04:43 +0000 (09:04 +0200)
commit58a96b64b6a32c16e11462b1a14556c8e963c259
tree421c2d22dd3acf72fa8636fdf68e241935aef874
parentd59d3dd26ca74ac583ead741172ed5b9b6bb3fc7
amd-xgbe: Use __napi_schedule() in BH context

[ Upstream commit d97b39484014281faa25114d43f35ff996142987 ]

The driver uses __napi_schedule_irqoff() which is fine as long as it is
invoked with disabled interrupts by everybody. Since the commit
mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq
context. This may lead to list corruption if another driver uses
__napi_schedule_irqoff() in IRQ context.

Use __napi_schedule() which safe to use from IRQ and softirq context.

Fixes: 89ea515977160 ("amd-xgbe: Re-issue interrupt if interrupt status not cleared")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/amd/xgbe/xgbe-drv.c