]> git.baikalelectronics.ru Git - kernel.git/commit
spi: cadence-quadspi: Remove spi_master_put() in probe failure path
authorVaishnav Achath <vaishnav.a@ti.com>
Wed, 1 Jun 2022 07:16:11 +0000 (12:46 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 6 Jun 2022 11:39:18 +0000 (12:39 +0100)
commit57bf6f82c9a1db67d6add586f4e924736d327b39
tree0bedb7aeaf2e8e151f43c78b9c78511098d3e936
parent609e09d90096a42ad39645bc58184a4be3ee7877
spi: cadence-quadspi: Remove spi_master_put() in probe failure path

Currently the spi_master is allocated by devm_spi_alloc_master()
and devres core manages the deallocation, but in probe failure
path spi_master_put() is being handled manually which causes
"refcount underflow use-after-free" warning when probe failure happens
after allocating spi_master.

Trimmed backtrace during failure:

refcount_t: underflow; use-after-free.
pc : refcount_warn_saturate+0xf4/0x144
Call trace:
refcount_warn_saturate
kobject_put
put_device
devm_spi_release_controller
devres_release_all

This commit makes relevant changes to remove spi_master_put() from probe
failure path.

Fixes: 4931b0a43a08 ("spi: cadence-quadspi: Handle spi_unregister_master() in remove()")
Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
Link: https://lore.kernel.org/r/20220601071611.11853-1-vaishnav.a@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c