]> git.baikalelectronics.ru Git - kernel.git/commit
Input: cap11xx - switch to using set_brightness_blocking()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 5 Feb 2019 21:52:26 +0000 (13:52 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 9 Feb 2019 16:56:56 +0000 (08:56 -0800)
commit57aeab113424768a3efe97c9c396f5772010812b
tree6ca375821759ee24104dd05cb3c44d73999e6b53
parent20744e982f61d853052e93959e4a30845bbd98c7
Input: cap11xx - switch to using set_brightness_blocking()

Updating LED state requires access to regmap and therefore we may sleep,
so we could not do that directly form set_brightness() method.
Historically we used private work to adjust the brightness, but with the
introduction of set_brightness_blocking() we no longer need it.

As a bonus, not having our own work item means we do not have
use-after-free issue as we neglected to cancel outstanding work on
driver unbind.

Reported-by: Sven Van Asbroeck <thesven73@gmail.com>
Reviewed-by: Sven Van Asbroeck <TheSven73@googlemail.com>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cap11xx.c