]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "dmaengine: qcom_hidma: Check for driver register failure"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:17 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:32:28 +0000 (18:32 +0200)
commit579fba231ffcddce1d1b98bc262ae82b3744f1bf
tree126b38c4d90a13e1b2f1863cfdbbcd3b165c7954
parent9a6f437cee902e9694ea371f2cc8ab07d41411cc
Revert "dmaengine: qcom_hidma: Check for driver register failure"

This reverts commit 4874a691e97909a420fdba937732920103f7be5e.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original change is NOT correct, as it does not correctly unwind from
the resources that was allocated before the call to
platform_driver_register().

Cc: Aditya Pakki <pakki001@umn.edu>
Acked-By: Vinod Koul <vkoul@kernel.org>
Acked-By: Sinan Kaya <okaya@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-51-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/qcom/hidma_mgmt.c