]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: seq: Don't allow resizing pool in use
authorTakashi Iwai <tiwai@suse.de>
Mon, 5 Mar 2018 21:00:55 +0000 (22:00 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 8 Mar 2018 07:59:26 +0000 (08:59 +0100)
commit56f2f22051ab2391c37438fb6bbf73b258544c8a
treedbe72abbd30b4eb2f85f2946d5c79ff42e886dbc
parent00ca9d2d522b523291aed2d6abe62a775146f752
ALSA: seq: Don't allow resizing pool in use

This is a fix for a (sort of) fallout in the recent commit
3fc8c5d0de94 ("ALSA: seq: Fix racy pool initializations") for
CVE-2018-1000004.
As the pool resize deletes the existing cells, it may lead to a race
when another thread is writing concurrently, eventually resulting a
UAF.

A simple workaround is not to allow the pool resizing when the pool is
in use.  It's an invalid behavior in anyway.

Fixes: 3fc8c5d0de94 ("ALSA: seq: Fix racy pool initializations")
Reported-by: 范龙飞 <long7573@126.com>
Reported-by: Nicolai Stange <nstange@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_clientmgr.c