]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: dts: aspeed: add LCLK setting into LPC KCS nodes
authorJae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Mon, 8 Nov 2021 19:01:58 +0000 (11:01 -0800)
committerJoel Stanley <joel@jms.id.au>
Tue, 21 Dec 2021 05:03:10 +0000 (15:33 +1030)
commit56eae81a8475df759523a4d78ef3f049bc606833
tree53c35ac8c8ef099b074346a39b4efae0d20e3502
parent7d867c3dce38c596519b748c170f6cc29f0b686f
ARM: dts: aspeed: add LCLK setting into LPC KCS nodes

If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS
hardware block will be enabled without heart beating of LCLK until
lpc-ctrl enables the LCLK. This issue causes improper handling on
host interrupts when the host sends interrupts in that time frame.
Then kernel eventually forcibly disables the interrupt with
dumping stack and printing a 'nobody cared this irq' message out.

To prevent this issue, all LPC sub drivers should enable LCLK
individually so this patch adds 'clocks' property setting into LPC
KCS node as one of required properties to enable the LCLK by the
LPC KCS driver.

Note: dtbs should be re-compiled after applying this change since
it's adding a new required property otherwise the driver will not
be probed correctly.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20211108190200.290957-5-jae.hyun.yoo@intel.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
arch/arm/boot/dts/aspeed-g5.dtsi
arch/arm/boot/dts/aspeed-g6.dtsi