]> git.baikalelectronics.ru Git - kernel.git/commit
libceph: be explicit in masking bottom 16 bits
authorAlex Elder <elder@inktank.com>
Fri, 29 Mar 2013 19:28:03 +0000 (14:28 -0500)
committerSage Weil <sage@inktank.com>
Thu, 2 May 2013 04:17:41 +0000 (21:17 -0700)
commit56cb5e86e699270440a4051b8fea87d27af9577f
tree30986227e5b5bdc0884066015ad78a3ce04bc79c
parent882140c5e04fc3bd6462aed137ea421d4f4bf531
libceph: be explicit in masking bottom 16 bits

In ceph_osdc_build_request() there is a call to cpu_to_le16() which
provides a 64-bit value as its argument.  Because of the implied
byte swapping going on it looked pretty suspect to me.

At the moment it turns out the behavior is well defined, but masking
off those bottom bits explicitly eliminates this distraction, and is
in fact more directly related to the purpose of the message header's
data_off field.

This resolves:
    http://tracker.ceph.com/issues/4125

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
net/ceph/osd_client.c