]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: change driver unbind order of the sdio function devices
authorArend Van Spriel <arend.vanspriel@broadcom.com>
Sat, 25 Nov 2017 20:39:25 +0000 (21:39 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 2 Dec 2017 15:22:47 +0000 (17:22 +0200)
commit56a7174905f6497e7680aea6d1338048aac91e72
tree61bbb5c6e5be90ef7f501116334d5502210b3b59
parent66fa33a535799ea442a91461e3715897bd2c5ad6
brcmfmac: change driver unbind order of the sdio function devices

In the function brcmf_sdio_firmware_callback() the driver is
unbound from the sdio function devices in the error path.
However, the order in which it is done resulted in a use-after-free
issue (see brcmf_ops_sdio_remove() in bcmsdh.c). Hence change
the order and first unbind sdio function #2 device and then
unbind sdio function #1 device.

Cc: stable@vger.kernel.org # v4.12.x
Fixes: 155d5520b669 ("brcmfmac: unbind all devices upon failure in firmware callback")
Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c