]> git.baikalelectronics.ru Git - kernel.git/commit
tty: serial: fsl_lpuart: add timeout for wait_event_interruptible in .shutdown()
authorSherry Sun <sherry.sun@nxp.com>
Fri, 3 Dec 2021 03:04:41 +0000 (11:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Dec 2021 13:00:05 +0000 (14:00 +0100)
commit56875961bbaec6ee88d3b0de95949fc196fab4a9
treea61b07e6acf1a0f8aef34c2790e12676fac39dd3
parent597bedafa0784cb1a675e6a9cabb80c945823ed0
tty: serial: fsl_lpuart: add timeout for wait_event_interruptible in .shutdown()

Use wait_event_interruptible in lpuart_dma_shutdown isn't a reasonable
behavior, since it may cause the system hang here if the condition
!sport->dma_tx_in_progress never to be true in some corner case, such as
when enable the flow control, the dma tx request may never be completed
due to the peer's CTS setting when run .shutdown().

So here change to use wait_event_interruptible_timeout instead of
wait_event_interruptible, the tx dma will be forcibly terminated if the
tx dma request cannot be completed within 300ms.
Considering the worst tx dma case is to have a 4K bytes tx buffer, which
would require about 300ms to complete when the baudrate is 115200.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Link: https://lore.kernel.org/r/20211203030441.22873-1-sherry.sun@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/fsl_lpuart.c