]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: tas2780: Fix set_tdm_slot in case of single slot
authorMartin Povišer <povik+lin@cutebit.org>
Thu, 27 Oct 2022 09:58:00 +0000 (11:58 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 31 Oct 2022 13:20:01 +0000 (13:20 +0000)
commit5675e90d54ba852369c6bbd602019011e6cc9c11
tree1ce227ae8e095041d3250cfc212ee6b23547f8a4
parent910d824e10de12b59becb89af91f6121208fd05c
ASoC: tas2780: Fix set_tdm_slot in case of single slot

There's a special branch in the set_tdm_slot op for the case of nslots
being 1, but:

 (1) That branch can never work (there's a check for tx_mask being
     non-zero, later there's another check for it *being* zero; one or
     the other always throws -EINVAL).

 (2) The intention of the branch seems to be what the general other
     branch reduces to in case of nslots being 1.

For those reasons remove the 'nslots being 1' special case.

Fixes: c37d61192b62 ("ASoC: add tas2780 driver")
Suggested-by: Jos Dehaes <jos.dehaes@gmail.com>
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20221027095800.16094-3-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2780.c