]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: add back stackpointer size checks
authorFlorian Westphal <fw@strlen.de>
Wed, 7 Feb 2018 12:46:25 +0000 (13:46 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 14 Feb 2018 19:47:41 +0000 (20:47 +0100)
commit5643742f9288460f9292ffe31ba6764c683eff41
tree8a048d1fd60cb33a795d292ab8eada5840826325
parente73d8eb1c35a19cd17a96b8c7097ff232946c650
netfilter: add back stackpointer size checks

The rationale for removing the check is only correct for rulesets
generated by ip(6)tables.

In iptables, a jump can only occur to a user-defined chain, i.e.
because we size the stack based on number of user-defined chains we
cannot exceed stack size.

However, the underlying binary format has no such restriction,
and the validation step only ensures that the jump target is a
valid rule start point.

IOW, its possible to build a rule blob that has no user-defined
chains but does contain a jump.

If this happens, no jump stack gets allocated and crash occurs
because no jumpstack was allocated.

Fixes: 695caa1b98f5d ("netfilter: xtables: don't save/restore jumpstack offset")
Reported-by: syzbot+e783f671527912cd9403@syzkaller.appspotmail.com
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/arp_tables.c
net/ipv4/netfilter/ip_tables.c
net/ipv6/netfilter/ip6_tables.c