]> git.baikalelectronics.ru Git - kernel.git/commit
clk: at91: fix possible dead lock in new drivers
authorAhmad Fatoum <a.fatoum@pengutronix.de>
Fri, 3 Jul 2020 07:32:35 +0000 (09:32 +0200)
committerStephen Boyd <sboyd@kernel.org>
Fri, 24 Jul 2020 09:18:42 +0000 (02:18 -0700)
commit562d23ad0b8cbb7f88671ea23507a381e61c59b3
tree8835d2cdfb4621fcb4a8ce2974d242e1c2d3566b
parent74a27a5f5a99e6b5adfd790053b6cccac3270c76
clk: at91: fix possible dead lock in new drivers

syscon_node_to_regmap() will make the created regmap get and enable the
first clock it can parse from the device tree. This clock is not needed to
access the registers and should not be enabled at that time.

Use device_node_to_regmap to resolve this as it looks up the regmap in
the same list but doesn't care about the clocks. This issue is detected
by lockdep when booting the sama5d3 with a device tree containing the
new clk bindings.

This fix already happened in 3eb77c03fd1e ("clk: at91: fix possible
deadlock") for the drivers that had been migrated to the new clk binding
back then. This does the same for the new drivers as well.

Fixes: 0847deaafccc ("clk: at91: add sam9x60 pmc driver")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.kernel.org/r/20200703073236.23923-1-a.fatoum@pengutronix.de
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/at91/at91sam9g45.c
drivers/clk/at91/at91sam9n12.c
drivers/clk/at91/sam9x60.c
drivers/clk/at91/sama5d3.c