]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Fri, 14 Apr 2017 03:43:01 +0000 (12:43 +0900)
committerTakashi Iwai <tiwai@suse.de>
Fri, 14 Apr 2017 06:57:25 +0000 (08:57 +0200)
commit552c1dbe6f60f049a64b0b1415bc6c8c431e578e
treec3ff17e8cd56cc2ffe199ad318797ee31aa18570
parent5f2ff3d0d0fa3ed993a0cf4a8ff1a6e4cfed4d9d
ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type

An abstraction of asynchronous transaction for transmission of MIDI
messages was introduced in Linux v4.4. Each driver can utilize this
abstraction to transfer MIDI messages via fixed-length payload of
transaction to a certain unit address. Filling payload of the transaction
is done by callback. In this callback, each driver can return negative
error code, however current implementation assigns the return value to
unsigned variable.

This commit changes type of the variable to fix the bug.

Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: <stable@vger.kernel.org> # 4.4+
Fixes: 0a8aaf9353c3 ("ALSA: firewire-lib: add helper functions for asynchronous transactions to transfer MIDI messages")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/lib.h