]> git.baikalelectronics.ru Git - kernel.git/commit
filter: fix sk_filter rcu handling
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 6 Dec 2010 17:29:43 +0000 (09:29 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Dec 2010 17:29:43 +0000 (09:29 -0800)
commit552b284290be4185e14179d375cc2936018aa292
tree4d2a200387242e1ed2d95ccd367c77750379e8cc
parent879243ac117394522470024e0c615cc24d2799e3
filter: fix sk_filter rcu handling

Pavel Emelyanov tried to fix a race between sk_filter_(de|at)tach and
sk_clone() in commit 2f826baf7ed296d5453

Problem is we can have several clones sharing a common sk_filter, and
these clones might want to sk_filter_attach() their own filters at the
same time, and can overwrite old_filter->rcu, corrupting RCU queues.

We can not use filter->rcu without being sure no other thread could do
the same thing.

Switch code to a more conventional ref-counting technique : Do the
atomic decrement immediately and queue one rcu call back when last
reference is released.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sock.h
net/core/filter.c