]> git.baikalelectronics.ru Git - kernel.git/commit
drm/atomic: Make async plane update checks work as intended, v2.
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Mon, 4 Sep 2017 10:48:38 +0000 (12:48 +0200)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fri, 8 Sep 2017 08:39:37 +0000 (10:39 +0200)
commit550ccf4c0b7a6d9f5039f280a7faf28192b5936a
treea82464679d2b22c8e231404d8126c3513542c629
parentc409e8d79b1722cff414302ea9980657ee2d522b
drm/atomic: Make async plane update checks work as intended, v2.

By always keeping track of the last commit in plane_state, we know
whether there is an active update on the plane or not. With that
information we can reject the fast update, and force the slowpath
to be used as was originally intended.

We cannot use plane_state->crtc->state here, because this only mentions
the most recent commit for the crtc, but not the planes that were part
of it. We specifically care about what the last commit involving this
plane is, which can only be tracked with a pointer in the plane state.

Changes since v1:
- Clean up the whole function here, instead of partially earlier.
- Add mention in the commit message why we need commit in plane_state.
- Swap plane->state in intel_legacy_cursor_update, instead of
  reassigning all variables. With this commit We know that the cursor
  is not part of any active commits so this hack can be removed.

Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20170904104838.23822-7-maarten.lankhorst@linux.intel.com
[mlankhorst: Amend commit for merge conflicts with drm-intel]
drivers/gpu/drm/drm_atomic_helper.c
drivers/gpu/drm/i915/intel_display.c
include/drm/drm_plane.h