]> git.baikalelectronics.ru Git - kernel.git/commit
cxgb4: fix IRQ free race during driver unload
authorShahjada Abul Husain <shahjada@chelsio.com>
Thu, 8 Jul 2021 16:21:56 +0000 (21:51 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Jul 2021 20:34:13 +0000 (13:34 -0700)
commit54eb22b1063b996f45fb4821a9bb0655f952c628
tree9351dd6b312f32133b19299939d989e15da50585
parentf395851b632bc34aba051c63d5a79e4e0cc155e8
cxgb4: fix IRQ free race during driver unload

IRQs are requested during driver's ndo_open() and then later
freed up in disable_interrupts() during driver unload.
A race exists where driver can set the CXGB4_FULL_INIT_DONE
flag in ndo_open() after the disable_interrupts() in driver
unload path checks it, and hence misses calling free_irq().

Fix by unregistering netdevice first and sync with driver's
ndo_open(). This ensures disable_interrupts() checks the flag
correctly and frees up the IRQs properly.

Fixes: d716f24e66f1 ("cxgb4: Disable interrupts and napi before unregistering netdev")
Signed-off-by: Shahjada Abul Husain <shahjada@chelsio.com>
Signed-off-by: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c