]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: adp5588: Do not use defined value for driver name and compatible
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 28 Jun 2022 19:39:04 +0000 (22:39 +0300)
committerBartosz Golaszewski <brgl@bgdev.pl>
Tue, 19 Jul 2022 07:57:13 +0000 (09:57 +0200)
commit54bfa58d66f1273bd59036854003e8d1baeef521
tree098d33f878d2db47b3a50e6ea17e09ad063a7ae8
parent4331efa7682c7fd881e6a211beb5e1a978e7d65c
gpio: adp5588: Do not use defined value for driver name and compatible

It's wrong to use defined string literal for three semantically different
cases, i.e.:
1) compatible string, which is part of ABI and has to have specific format;
2) I2C ID, which is user space visible and also ABI;
3) driver name, that can be changed.

Drop the define and use appropriate string literals in place.

While at it, drop comma at terminator entry of OF ID table.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-adp5588.c