]> git.baikalelectronics.ru Git - kernel.git/commit
igc: igc_write_phy_reg_gpy: drop premature return
authorSasha Neftin <sasha.neftin@intel.com>
Sun, 20 Feb 2022 07:29:15 +0000 (09:29 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 28 Feb 2022 16:48:45 +0000 (08:48 -0800)
commit54b9cc22ac110762645eceadb344aa0579a31004
tree1a6a89c04ac5e75aac77542106c12f85672ed8d5
parent3de8264f2d5b90ba2c4fab0b2030721789ab7c87
igc: igc_write_phy_reg_gpy: drop premature return

Similar to "igc_read_phy_reg_gpy: drop premature return" patch.
igc_write_phy_reg_gpy checks the return value from igc_write_phy_reg_mdic
and if it's not 0, returns immediately. By doing this, it leaves the HW
semaphore in the acquired state.

Drop this premature return statement, the function returns after
releasing the semaphore immediately anyway.

Fixes: f2c4d6854520 ("igc: Add code for PHY support")
Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Reported-by: Corinna Vinschen <vinschen@redhat.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_phy.c