]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: mic_x100_dma: use devm_kzalloc to fix an issue
authorHuang Shijie <sjhuang@iluvatar.ai>
Wed, 22 Aug 2018 02:40:27 +0000 (10:40 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 27 Aug 2018 05:46:04 +0000 (11:16 +0530)
commit54625cc67d7bc8ea94e73b28558b59d9733f3c75
tree8f50bd17840261c04a0853ff21a4e083204b7f25
parent0ff97265403d59a684be8666710156706ccfd8fa
dmaengine: mic_x100_dma: use devm_kzalloc to fix an issue

The following patch introduced an issue.
    commit ede1705510dd ("dmaengine: mic_x100_dma: use the new helper to simplify the code")

This issue is :

kfree(mic_dma_dev)
.....
dma_async_device_unregister(mic_dma_dev->device);

Free the memory, and use it again.

So use devm_kzalloc to allocate mic_dma_dev to fix it.

When the Devres try to release the resources, it will call release at the
following order:

dma_async_device_unregister(mic_dma_dev->device);
.....
kfree(mic_dma_dev)

Fixes: ede1705510dd ("dmaengine: mic_x100_dma: use the new helper to simplify the code")
Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mic_x100_dma.c