]> git.baikalelectronics.ru Git - kernel.git/commit
drm/edid: fix invalid EDID extension block filtering
authorJani Nikula <jani.nikula@intel.com>
Wed, 30 Mar 2022 17:04:26 +0000 (20:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:44 +0000 (10:22 +0200)
commit544b759de2e6151c615d6f110b57114ab30b4334
treefe280d0abbc4a584996dacbb93d11c75b8ffd505
parent380d88d318df14969cfbf14ce5baf0c13df2d1ab
drm/edid: fix invalid EDID extension block filtering

[ Upstream commit 7d67515a4fcab1f6fdcfd4b384af37d68b183014 ]

The invalid EDID block filtering uses the number of valid EDID
extensions instead of all EDID extensions for looping the extensions in
the copy. This is fine, by coincidence, if all the invalid blocks are at
the end of the EDID. However, it's completely broken if there are
invalid extensions in the middle; the invalid blocks are included and
valid blocks are excluded.

Fix it by modifying the base block after, not before, the copy.

Fixes: 68b5a7812577 ("drm/edid: Only print the bad edid when aborting")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220330170426.349248-1-jani.nikula@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/drm_edid.c