]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: pca953x: do not ignore i2c errors
authorAndrey Gusakov <andrey.gusakov@cogentembedded.com>
Thu, 23 Sep 2021 17:22:16 +0000 (20:22 +0300)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 29 Sep 2021 18:40:15 +0000 (20:40 +0200)
commit540cffbab8b8e6c52a4121666ca18d6e94586ed2
treed571d6022f90aef4d3e54b4e0c7a85b44546258d
parent5816b3e6577eaa676ceb00a848f0fd65fe2adc29
gpio: pca953x: do not ignore i2c errors

Per gpio_chip interface, error shall be proparated to the caller.

Attempt to silent diagnostics by returning zero (as written in the
comment) is plain wrong, because the zero return can be interpreted by
the caller as the gpio value.

Cc: stable@vger.kernel.org
Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-pca953x.c