]> git.baikalelectronics.ru Git - kernel.git/commit
xen: selfballoon: remove unnecessary static in frontswap_selfshrink()
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 4 Jul 2017 18:34:05 +0000 (13:34 -0500)
committerJuergen Gross <jgross@suse.com>
Thu, 27 Jul 2017 17:55:41 +0000 (19:55 +0200)
commit53eb093964dfb4ea93b986183849b67d145f5a12
treec338e3c2d7002a69552aa3d5992078450ea56608
parent6e203ad5154bc191b5fac084af18e38870466820
xen: selfballoon: remove unnecessary static in frontswap_selfshrink()

Remove unnecessary static on local variables last_frontswap_pages and
tgt_frontswap_pages. Such variables are initialized before being used,
on every execution path throughout the function. The statics have no
benefit and, removing them reduce the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

You can see a significant difference in the code size after executing
the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
   5633    3452     384    9469    24fd drivers/xen/xen-selfballoon.o

after:
   text    data     bss     dec     hex filename
   5576    3308     256    9140    23b4 drivers/xen/xen-selfballoon.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/xen-selfballoon.c