]> git.baikalelectronics.ru Git - kernel.git/commit
arm/asm: add loglvl to c_backtrace()
authorDmitry Safonov <dima@arista.com>
Tue, 9 Jun 2020 04:30:07 +0000 (21:30 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 9 Jun 2020 16:39:10 +0000 (09:39 -0700)
commit5376b1e7613969dc10e8a9eb31bb144ff85ecaa7
treeda45382c2f04f70bf5f8abecb8132baf70f38874
parenta7f58e9818181cd369add0da34a7749e97a153b4
arm/asm: add loglvl to c_backtrace()

Currently, the log-level of show_stack() depends on a platform
realization.  It creates situations where the headers are printed with
lower log level or higher than the stacktrace (depending on a platform or
user).

Furthermore, it forces the logic decision from user to an architecture
side.  In result, some users as sysrq/kdb/etc are doing tricks with
temporary rising console_loglevel while printing their messages.  And in
result it not only may print unwanted messages from other CPUs, but also
omit printing at all in the unlucky case where the printk() was deferred.

Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier
approach than introducing more printk buffers.  Also, it will consolidate
printings with headers.

Add log level argument to c_backtrace() as a preparation for introducing
show_stack_loglvl().

[1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u

Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Will Deacon <will@kernel.org>
Link: http://lkml.kernel.org/r/20200418201944.482088-5-dima@arista.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/arm/include/asm/bug.h
arch/arm/include/asm/traps.h
arch/arm/kernel/traps.c
arch/arm/kernel/unwind.c
arch/arm/lib/backtrace-clang.S
arch/arm/lib/backtrace.S