]> git.baikalelectronics.ru Git - kernel.git/commit
specialix.c: convert nested spin_lock_irqsave to spin_lock
authorJulia Lawall <julia@diku.dk>
Mon, 20 Jul 2009 15:05:07 +0000 (16:05 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 20 Jul 2009 23:38:43 +0000 (16:38 -0700)
commit531c22f258fdd926a02822076c369be729517efa
tree750ec8042d629b48cb04e869d3b97496f51c717a
parent6bb0347c313db251d6e4994e724c401b9b1d4b6f
specialix.c: convert nested spin_lock_irqsave to spin_lock

If spin_lock_irqsave is called twice in a row with the same second
argument, the interrupt state at the point of the second call overwrites
the value saved by the first call.  Indeed, the second call does not
need to save the interrupt state, so it is changed to a simple
spin_lock.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression lock1,lock2;
expression flags;
@@

*spin_lock_irqsave(lock1,flags)
... when != flags
*spin_lock_irqsave(lock2,flags)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/specialix.c