]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 22 Jun 2020 11:05:40 +0000 (13:05 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jun 2020 12:50:26 +0000 (13:50 +0100)
commit53116d76a5a14830cbf408d280c285cf7455234a
tree8693e37d77bb3382066df3b68950098964c2a4d8
parent27855f77b1cf857f75daf547d8a400c656f761ad
spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer

During device removal, the driver should unregister the SPI controller
and stop the hardware.  Otherwise the dspi_transfer_one_message() could
wait on completion infinitely.

Additionally, calling spi_unregister_controller() first in device
removal reverse-matches the probe function, where SPI controller is
registered at the end.

Fixes: fafa34a912f9 ("spi: fsl-dspi: add missing clk_disable_unprepare() in dspi_remove()")
Reported-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200622110543.5035-1-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-dspi.c