]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_queue: reject NF_STOLEN verdicts from userspace
authorFlorian Westphal <fw@strlen.de>
Tue, 30 Aug 2011 13:01:20 +0000 (15:01 +0200)
committerPatrick McHardy <kaber@trash.net>
Tue, 30 Aug 2011 13:01:20 +0000 (15:01 +0200)
commit52efe2fac9b0e1985432ada016918e5b97e7db9f
tree3d1b9b71059be24fe3a35411eecc62000bba5abc
parent23123c980026c576c1aaba1d92708ef7d295377b
netfilter: nf_queue: reject NF_STOLEN verdicts from userspace

A userspace listener may send (bogus) NF_STOLEN verdict, which causes skb leak.

This problem was previously fixed via
b2c64fbea7acd5eaeb3739b351b95ffdcbaad508 (netfilter:
nf_queue: fix NF_STOLEN skb leak) but this had to be reverted because
NF_STOLEN can also be returned by a netfilter hook when iterating the
rules in nf_reinject.

Reject userspace NF_STOLEN verdict, as suggested by Michal Miroslaw.

This is complementary to commit e03aa8f6c1b122bc6f5be618f50462e9e3e27e77
(netfilter: avoid double free in nf_reinject).

Cc: Julian Anastasov <ja@ssi.bg>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/ipv4/netfilter/ip_queue.c
net/ipv6/netfilter/ip6_queue.c
net/netfilter/nfnetlink_queue.c