]> git.baikalelectronics.ru Git - kernel.git/commit
[XTENSA]: Fix use of skb after netif_rx
authorJulia Lawall <julia@diku.dk>
Tue, 11 Dec 2007 01:16:56 +0000 (17:16 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Tue, 11 Dec 2007 10:45:28 +0000 (02:45 -0800)
commit51f196d3bf04ff530916a1e6c3a904703923c936
treec60015bd19092e936d9aa492ab6f74e10258c6ec
parent7165bb6ecb1fac2e48a8602d33788e6f41fa8e43
[XTENSA]: Fix use of skb after netif_rx

Recently, Wang Chen submitted a patch
(160c1d398386eeabc97f364d22676cc8cf59912e) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument.  The same problem occurs in some other drivers as well.

This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression skb, e,e1;
@@

(
 netif_rx(skb);
|
 netif_rx_ni(skb);
)
  ... when != skb = e
(
  skb = e1
|
* skb
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/xtensa/platform-iss/network.c