]> git.baikalelectronics.ru Git - kernel.git/commit
MIPS: Remove repetitive increase irq_err_count
authorhuhai <huhai@kylinos.cn>
Fri, 10 Jun 2022 11:14:20 +0000 (19:14 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Tue, 21 Jun 2022 14:50:58 +0000 (16:50 +0200)
commit51f191c59592f818b8def704727c43091b39477e
tree67fcadfb0dee852b7e9318f1ba5afe56244c0b27
parent08aafa0d475a08e31a13403e9df41c7179f4bdcd
MIPS: Remove repetitive increase irq_err_count

commit ab4fd97bb851 ("[PATCH] mips: update IRQ handling for vr41xx") added
a function irq_dispatch, and it'll increase irq_err_count when the get_irq
callback returns a negative value, but increase irq_err_count in get_irq
was not removed.

And also, modpost complains once gpio-vr41xx drivers become modules.
  ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!

So it would be a good idea to remove repetitive increase irq_err_count in
get_irq callback.

Fixes: cc5be02f60c6 ("MIPS: Update VR41xx GPIO driver to use gpiolib")
Fixes: ab4fd97bb851 ("[PATCH] mips: update IRQ handling for vr41xx")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: huhai <huhai@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/vr41xx/common/icu.c
drivers/gpio/gpio-vr41xx.c