]> git.baikalelectronics.ru Git - kernel.git/commit
ipv4: do not use per netns icmp sockets
authorEric Dumazet <edumazet@google.com>
Mon, 24 Jan 2022 20:24:55 +0000 (12:24 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Jan 2022 11:25:21 +0000 (11:25 +0000)
commit51ac91f9c18f8e27c0231f4b17a09f9745bf4e95
treedff2f3378a0fadd25de420192817717b86d064f2
parent1b9c1dc21d137b32a032366235f72b8295a3ad1a
ipv4: do not use per netns icmp sockets

Back in linux-2.6.25 (commit c592dca5df3f "[NETNS]: Make icmp_sk per namespace."),
we added private per-cpu/per-netns ipv4 icmp sockets.

This adds memory and cpu costs, which do not seem needed.
Now typical servers have 256 or more cores, this adds considerable
tax to netns users.

icmp sockets are used from BH context, are not receiving packets,
and do not store any persistent state but the 'struct net' pointer.

icmp_xmit_lock() already makes sure to lock the chosen per-cpu
socket.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/netns/ipv4.h
net/ipv4/icmp.c