]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/cell: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 20 Nov 2015 20:33:24 +0000 (21:33 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 25 Nov 2021 00:25:29 +0000 (11:25 +1100)
commit5124d2658a3be64cfeff5e8bb48c02a52dda5bf2
tree80214c718a21f8b567df518b110986022d162813
parenta91b7ab8123c7d6302209b8f344b3f9c61d8b32a
powerpc/cell: add missing of_node_put

for_each_node_by_name performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression e,e1;
local idexpression n;
@@

 for_each_node_by_name(n, e1) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1448051604-25256-7-git-send-email-Julia.Lawall@lip6.fr
arch/powerpc/platforms/cell/iommu.c