]> git.baikalelectronics.ru Git - kernel.git/commit
jffs2: Fix mounting under new mount API
authorDavid Howells <dhowells@redhat.com>
Thu, 26 Sep 2019 14:21:18 +0000 (15:21 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 26 Sep 2019 14:26:55 +0000 (10:26 -0400)
commit50fab5da0cf51cb751b1b2626e4164c8c1f26cc5
treebdcd852bab324000d1f31e3082c51c94760f8207
parent5bd3fbf09e79088fc007d91cab9e9a4a9ddfaa89
jffs2: Fix mounting under new mount API

The mounting of jffs2 is broken due to the changes from the new mount API
because it specifies a "source" operation, but then doesn't actually
process it.  But because it specified it, it doesn't return -ENOPARAM and
the caller doesn't process it either and the source gets lost.

Fix this by simply removing the source parameter from jffs2 and letting the
VFS deal with it in the default manner.

To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase
block size parameters, then try and mount the /dev/mtdblock<N> file that
that creates as jffs2.  No need to initialise it.

Fixes: fcbbe5f452a2 ("vfs: Convert jffs2 to use the new mount API")
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: David Woodhouse <dwmw2@infradead.org>
cc: Richard Weinberger <richard@nod.at>
cc: linux-mtd@lists.infradead.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/jffs2/super.c