]> git.baikalelectronics.ru Git - kernel.git/commit
lkdtm/bugs: Check for the NULL pointer after calling kmalloc
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Thu, 20 Jan 2022 09:29:36 +0000 (17:29 +0800)
committerKees Cook <keescook@chromium.org>
Tue, 12 Apr 2022 23:11:49 +0000 (16:11 -0700)
commit50e7025a20e13a11531444aa447b235f32248ff4
tree16bd4ab8d7cb8a3de607d87c9bb879b22bc7e963
parentc02c8228f39a35a18b7da5bed4327a96bdd1c782
lkdtm/bugs: Check for the NULL pointer after calling kmalloc

As the possible failure of the kmalloc(), the not_checked and checked
could be NULL pointer.
Therefore, it should be better to check it in order to avoid the
dereference of the NULL pointer.
Also, we need to kfree the 'not_checked' and 'checked' to avoid
the memory leak if fails.
And since it is just a test, it may directly return without error
number.

Fixes: 42ee4c6d0b03 ("drivers/misc/lkdtm/bugs.c: add arithmetic overflow and array bounds checks")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220120092936.1874264-1-jiasheng@iscas.ac.cn
drivers/misc/lkdtm/bugs.c