]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amd/display: Fix off by one in hdmi_14_process_transaction()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 2 Mar 2021 11:15:48 +0000 (14:15 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 3 Mar 2021 15:51:37 +0000 (10:51 -0500)
commit506f0bf666a466e68e61463a150d0243c9233648
treef011ca9c8a1f490a834682adf4ca793160906c78
parent6b76bfab8cc05174e5cde49e35a29a89956f41dd
drm/amd/display: Fix off by one in hdmi_14_process_transaction()

The hdcp_i2c_offsets[] array did not have an entry for
HDCP_MESSAGE_ID_WRITE_CONTENT_STREAM_TYPE so it led to an off by one
read overflow.  I added an entry and copied the 0x0 value for the offset
from similar code in drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c.

I also declared several of these arrays as having HDCP_MESSAGE_ID_MAX
entries.  This doesn't change the code, but it's just a belt and
suspenders approach to try future proof the code.

Fixes: aaef6d565496 ("drm/amd/display: Add HDCP module")
Reviewed-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c