]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: Fix off by one in dsa_loop_port_vlan_add()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 19 Jan 2021 14:53:35 +0000 (17:53 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 Jan 2021 01:10:04 +0000 (17:10 -0800)
commit5063811c05d9940e28d32fe08d9381684f922921
tree38879d905567fff39e9d594dfc6fad9e2d1e4e61
parentde74594606861e17b44d23a6104ab16a5a4e98e6
net: dsa: Fix off by one in dsa_loop_port_vlan_add()

The > comparison is intended to be >= to prevent reading beyond the
end of the ps->vlans[] array.  It doesn't affect run time though because
the ps->vlans[] array has VLAN_N_VID (4096) elements and the vlan->vid
cannot be > 4094 because it is checked earlier.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/YAbyb5kBJQlpYCs2@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/dsa_loop.c