]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings"
authorPhilippe Reynes <tremyfr@gmail.com>
Fri, 8 Jul 2016 22:54:47 +0000 (00:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Jul 2016 19:57:09 +0000 (12:57 -0700)
commit50404fc45925d1db6efeae730fb6511c4ca15d2d
tree09c861535684a7de751a9fdb08fcf2e703788259
parent57b4485079fa85a9c91c5354a861b6687bc3fddb
Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings"

This reverts commit f19f8ac0cc53 ("net: ethernet: bcmgenet: use
phy_ethtool_{get|set}_link_ksettings")

This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings
don't check if the device is running, but the driver bcmgenet need this
check.

The function {get|set}_settings need to access the mdio bus, and this
bus may only be used when the device is running. Otherwise, the clock
is disable and a mdio access will fail.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c