]> git.baikalelectronics.ru Git - kernel.git/commit
nfp: disable netpoll on representors
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 27 Mar 2019 18:38:39 +0000 (11:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Mar 2019 00:04:29 +0000 (17:04 -0700)
commit4fdbfa3ba5ddf6971372b5e09f3a50777f0ffe1b
tree209ec324c54aa74710dbf84a70c32e15337b4ad1
parent94851c9512d8bd0e8d0601a90da94e41bec07a94
nfp: disable netpoll on representors

NFP reprs are software device on top of the PF's vNIC.
The comment above __dev_queue_xmit() sayeth:

 When calling this method, interrupts MUST be enabled.  This is because
 the BH enable code must have IRQs enabled so that it will not deadlock.

For netconsole we can't guarantee IRQ state, let's just
disable netpoll on representors to be on the safe side.

When the initial implementation of NFP reprs was added by the
commit c9c332788635 ("nfp: general representor implementation")
.ndo_poll_controller was required for netpoll to be enabled.

Fixes: 12b3c16a7c5b ("netpoll: make ndo_poll_controller() optional")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c