]> git.baikalelectronics.ru Git - kernel.git/commit
asm-generic/tlb: avoid potential double flush
authorPeter Zijlstra <peterz@infradead.org>
Tue, 4 Feb 2020 01:36:53 +0000 (17:36 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 4 Feb 2020 03:05:26 +0000 (03:05 +0000)
commit4f7456c3f99a69cee82947f6322039ffffac6ead
treefdfe709ddee4d1781db6a36fbdea1c31a60ebc01
parent02adfe0a5f7c8ff9b59f358227eec68421e50df5
asm-generic/tlb: avoid potential double flush

Aneesh reported that:

tlb_flush_mmu()
  tlb_flush_mmu_tlbonly()
    tlb_flush() <-- #1
  tlb_flush_mmu_free()
    tlb_table_flush()
      tlb_table_invalidate()
tlb_flush_mmu_tlbonly()
  tlb_flush() <-- #2

does two TLBIs when tlb->fullmm, because __tlb_reset_range() will not
clear tlb->end in that case.

Observe that any caller to __tlb_adjust_range() also sets at least one of
the tlb->freed_tables || tlb->cleared_p* bits, and those are
unconditionally cleared by __tlb_reset_range().

Change the condition for actually issuing TLBI to having one of those bits
set, as opposed to having tlb->end != 0.

Link: http://lkml.kernel.org/r/20200116064531.483522-4-aneesh.kumar@linux.ibm.com
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Reported-by: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/asm-generic/tlb.h