]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/message: move dereference after NULL test
authorJulia Lawall <julia@diku.dk>
Wed, 11 Aug 2010 01:01:14 +0000 (18:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Aug 2010 15:59:00 +0000 (08:59 -0700)
commit4f662334d95eeb6ac5034bb3a60399c5ae6ec851
treed53b466dbc3d2be81e9b88cb014ce2bb331da9d2
parent27cd3117835ea8ab40958014b79c8cb6dbab309d
drivers/message: move dereference after NULL test

If the NULL test on dev->i2o_dev or i2o_dev is needed, then the dereference
should be after the NULL test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@suse.de>
Cc: Kashyap Desai <kashyap.desai@lsi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/message/i2o/i2o_block.c
drivers/message/i2o/i2o_scsi.c