]> git.baikalelectronics.ru Git - kernel.git/commit
USB: revert periodic scheduling bugfix
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 28 May 2013 18:03:10 +0000 (14:03 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 May 2013 01:41:06 +0000 (10:41 +0900)
commit4efaaeba93fd9b17f904147de133bc5c2b3d8070
tree37c2724f185e176ae31f329b782edaf9d85acbbc
parent7ff6b0a09cf19fe68713f4e071179c7c98c88a6c
USB: revert periodic scheduling bugfix

This patch reverts commit 254f7295a507874062b97fe9d89ca6e28c1d03d9
(USB: EHCI: fix bug in scheduling periodic split transfers).  The
commit was valid -- it fixed a real bug -- but the periodic scheduler
in ehci-hcd is in such bad shape (especially the part that handles
split transactions) that fixing one bug is very likely to cause
another to surface.  That's what happened in this case; the result was
choppy and noisy playback on certain 24-bit audio devices.

The only real fix will be to rewrite this entire section of code.  My
next project...

This fixes https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110.

Thanks to Tim Richardson for extra testing and feedback, and to Joseph
Salisbury and Tyson Tan for tracking down the original source of the
problem.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: Joseph Salisbury <joseph.salisbury@canonical.com>
CC: Tim Richardson <tim@tim-richardson.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-sched.c