]> git.baikalelectronics.ru Git - kernel.git/commit
net: encx24j600: Add parentheses to fix precedence
authorValentina Goncharenko <goncharenko.vp@ispras.ru>
Thu, 1 Dec 2022 17:34:07 +0000 (20:34 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2022 09:46:31 +0000 (09:46 +0000)
commit4e1d3356f357e7f714b4d8b603fde93d1a77ae03
tree5473967e836487dd5b9b38b5416015b1017629d7
parent8926a7d823f38bcaf4511acd7a6c169cbc6f5b87
net: encx24j600: Add parentheses to fix precedence

In functions regmap_encx24j600_phy_reg_read() and
regmap_encx24j600_phy_reg_write() in the conditions of the waiting
cycles for filling the variable 'ret' it is necessary to add parentheses
to prevent wrong assignment due to logical operations precedence.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2b27d5f85455 ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/encx24j600-regmap.c