]> git.baikalelectronics.ru Git - kernel.git/commit
RDMA/core: Fix use of logical OR in get_new_pps
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 17 Feb 2020 20:43:18 +0000 (13:43 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 19 Feb 2020 20:42:12 +0000 (16:42 -0400)
commit4db8e45ccdbc54304fc9cb0f063068fb2ce7deec
tree51c612d6ee4c93623f198706c4161fdf5546a40f
parentc4d0ee29cb57f8771ff06c6950abffdfdf6cf223
RDMA/core: Fix use of logical OR in get_new_pps

Clang warns:

../drivers/infiniband/core/security.c:351:41: warning: converting the
enum constant to a boolean [-Wint-in-bool-context]
        if (!(qp_attr_mask & (IB_QP_PKEY_INDEX || IB_QP_PORT)) && qp_pps) {
                                               ^
1 warning generated.

A bitwise OR should have been used instead.

Fixes: 531503192c03 ("RDMA/core: Fix protection fault in get_pkey_idx_qp_list")
Link: https://lore.kernel.org/r/20200217204318.13609-1-natechancellor@gmail.com
Link: https://github.com/ClangBuiltLinux/linux/issues/889
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/security.c