]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: SND_INTEL_DSP_CONFIG dependency
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 22 Jan 2021 00:57:25 +0000 (18:57 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 25 Jan 2021 12:53:42 +0000 (12:53 +0000)
commit4daa74ef2e6d416af406f724649edb099850ff62
tree6977a904e510548d5637d9b4e4728b499742f383
parentdc9a791cd4320fd305f254c44bfee05baf66cd30
ASoC: SOF: SND_INTEL_DSP_CONFIG dependency

The sof-pci-dev driver fails to link when built into the kernel
and CONFIG_SND_INTEL_DSP_CONFIG is set to =m:

arm-linux-gnueabi-ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
sof-pci-dev.c:(.text+0x1c): undefined reference to `snd_intel_dsp_driver_probe'

As a temporary fix, use IS_REACHABLE to prevent the problem from
happening. A more complete solution is to move this code to
Intel-specific parts, restructure the drivers and Kconfig as discussed
with Arnd Bergmann and Takashi Iwai.

Fixes: 50fa4538b197 ("ALSA: hda: add Intel DSP configuration / probe code")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210122005725.94163-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-acpi-dev.c
sound/soc/sof/sof-pci-dev.c