]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amd/display: Fix stream->link_enc unassigned during stream removal
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tue, 25 Jan 2022 17:04:34 +0000 (12:04 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Feb 2022 23:01:17 +0000 (18:01 -0500)
commit4d8cecfe60bddbea5a2fe21d9c684d786ffb5496
tree934c190f9a8bb4f3d0b22a830a7add9319a655e7
parent3dfc7345db974db06359bf4539edf14e42c7c435
drm/amd/display: Fix stream->link_enc unassigned during stream removal

[Why]
Found when running igt@kms_atomic.

Userspace attempts to do a TEST_COMMIT when 0 streams which calls
dc_remove_stream_from_ctx. This in turn calls link_enc_unassign
which ends up modifying stream->link = NULL directly, causing the
global link_enc to be removed preventing further link activity
and future link validation from passing.

[How]
We take care of link_enc unassignment at the start of
link_enc_cfg_link_encs_assign so this call is no longer necessary.

Fixes global state from being modified while unlocked.

Reviewed-by: Jimmy Kizito <Jimmy.Kizito@amd.com>
Acked-by: Jasdeep Dhillon <jdhillon@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_resource.c